to attach, or not to attach?

Luke Yelavich luke.yelavich at canonical.com
Sun Feb 14 21:58:44 CET 2010


On Sun, Feb 14, 2010 at 11:09:28PM EST, Chris Brannon wrote:
> Halim Sahin wrote:
> > Hi,
> > Thx for you work but please can you send the patches as attachmnent?
> 
> I basicly concur with William on this issue,
> for the following three reasons.
> 
> 1. Inline patches are easier to review.
> 2. They are customary in many git-using email-based communities, notably
> the Linux Kernel Mailing List.
> 3. By default, git format-patch gives inline patches.
> Three is likely a corollary of two.
> 
> There is one good counter-argument against inlining.
> If some list members are using a version control system other than git, then
> they will have an easier time with attachments.

I personally agree. I simply need to save the patch emails to a patches box, and run git am over that box.

Luke



More information about the Speechd mailing list