[PATCH (speechd) 2/2] Properly quote variable expansions.

Christopher Brannon cmbrannon79 at gmail.com
Sat Feb 27 18:29:16 CET 2010


The previous version of src/python/Makefile.in
does not quote all variable references.
If spaces are used in directory names, make will probably fail at
install-time.
---
 src/python/Makefile.in |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/python/Makefile.in b/src/python/Makefile.in
index b7357cf..386125d 100644
--- a/src/python/Makefile.in
+++ b/src/python/Makefile.in
@@ -24,17 +24,17 @@ install:
 	else \
 		echo "Python not found, not installing speechd module nor spd-conf"; \
 	fi
-	cp speechd_config/test.wav ${DESTDIR}@snddatadir@
+	cp speechd_config/test.wav "${DESTDIR}@snddatadir@"
 
-	if test ! -d ${DESTDIR}@spddesktopconforigdir@; then \
-		mkdir -p ${DESTDIR}@spddesktopconforigdir@; \
+	if test ! -d "${DESTDIR}@spddesktopconforigdir@"; then \
+		mkdir -p "${DESTDIR}@spddesktopconforigdir@"; \
 	fi
 
-	cp speechd_config/speechd.desktop ${DESTDIR}@spddesktopconforigdir@/
+	cp speechd_config/speechd.desktop "${DESTDIR}@spddesktopconforigdir@/"
 
 uninstall:
-	rm -f ${DESTDIR}@snddatadir@/test.wav
-	rm -rf ${DESTDIR}@spddesktopconforigdir@
+	rm -f "${DESTDIR}@snddatadir@/test.wav"
+	rm -rf "${DESTDIR}@spddesktopconforigdir@"
 
 clean:
 	rm -f *.pyc
-- 
1.7.0




More information about the Speechd mailing list