[PATCH 2/2] rename spd_conv functions to spd_*
w.d.hubbs at gmail.com
Sat Oct 2 01:20:36 CEST 2010
On Fri, Oct 01, 2010 at 12:59:32AM +0200, Andrei Kholodnyi wrote:
> On Fri, Oct 1, 2010 at 12:47 AM, Andrei Kholodnyi
> <andrei.kholodnyi at gmail.com> wrote:
> > On Fri, Oct 1, 2010 at 12:21 AM, Trevor Saunders
> > <trev.saunders at gmail.com> wrote:
> >> Hi,
> >> On Thu, Sep 30, 2010 at 10:27:58PM +0200, Andrei Kholodnyi wrote:
> >>> functions renamed according to the filename
> >> hmm, I'm not sure I see any purpose in this. ?Also I don't think there's
> >> any reason for the functions to have an spd_ prefix since we don't
> >> expose them outside of the project.
> >> Trev
> > Hi Trev,
> > back to my favorite topic - coding conventions, lol.
> > I need to dig out my proposal.
> > well, since these functions are used across the whole project and
> > included in libcommon
> > it make sense to name all of them starting with spd_ prefix.
> >> we don't expose them outside of the project.
> actually we expose them since they are used in modules.
They are used in our modules, yes, but I think he means that they are
not public, in the sense that if someone writes an independent module
that is not part of our source tree they can't use them. I would agree
that these are internal functions.
I will look at the patches though and see what I think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the Speechd