[PATCH] Add i18n utilities to common library
andrei.kholodnyi at gmail.com
Wed Oct 6 07:00:44 CEST 2010
Actually it is not a responsibility of the intl module to decide
whether to abort speechd server or not, but rather the caller (server)
However I'm fine with this solution for now.
On 10/6/10, Rui Batista <ruiandrebatista at gmail.com> wrote:
> Ter, 2010-10-05 às 17:59 -0500, William Hubbs escreveu:
>> Hi Rui,
>> On Tue, Oct 05, 2010 at 09:44:31PM +0200, Andrei Kholodnyi wrote:
>> > > setlocale doesn't return nothing we can check for errors...
>> > > The other two return NULL on out of memory. In this case what should
>> > > we
>> > > do? Abort?
>> > I think just return an error e.g. -1 and let caller decide what to do.
>> Most of our other out of memory situations are handled by glib's
>> allocation routines which abort in that situation, so, for consistency,
>> I would vote for aborting. That also means you don't have to change
>> your functions to return values.
> I can make it either way: aborting or returning status code. But I do
> also vote for aborting. Should I repost the patch with abort calls?
> Rui Batista
> Speechd mailing list
> Speechd at lists.freebsoft.org
Sent from my mobile device
Believe is not enough, you must know
More information about the Speechd