Before the patch: bugs in generic module
andrei.kholodnyi at gmail.com
Wed Dec 8 13:03:32 CET 2010
On Wed, Dec 8, 2010 at 8:11 AM, Bohdan R. Rau <ethanak at polip.com> wrote:
> Hi all
> After careful reading generic module source I decided to rewrite it almost
> from scratch. I don't expect working version in nearest days, and even I'm
> not sure my code will be accepted.
probably you could highlight your design ideas before you start rewriting it,
e.g. by sending "RFC: new generic module design"
> In meantime I found some bugs in generic module...
> 1) generic module does not show voice list.
> Funny. I wrote a small piece of code, but I think there is a bug in other
> place: if in AddVoice I use spaces in voice name, LIST SYNTHESIS_VOICES
> command works incorrectly.
> As I couldn't find any informations regarding spaces in synthesis voice
> names, there is a bug for me.
Let me drop a look into it.
It parses fields based on " " as a separator.
We might introduce some extra consistency checks.
> One possible solution is to replace spaces into underscores in AddVoice callback.
> Should I provide patch for it?
> Source of my module_list_voices for generic module below - sorry not as
> patch, but as it's not complete please treat it only as code to review.
I'll review these two code snippets as well.
More information about the Speechd